fix: Encapsulates subscription steam consumption #170
Conversation
This fixes an issue observed in downstream code, where awaiting a GraphQL subscription with `makeAsyncIterator().next()` results in an error of `Fatal error: attempt to await next() on more than one task`. This encapsulates the consumption of the underlying resolver stream in a single cancellable task so that downstream code does not share the underlying stream iterator.
NeedleInAJayStack
force-pushed
the
fix/stream-concurrency
branch
from
b8468fb to
34cd941
Compare
JaapWijnen
left a comment
JaapWijnen
left a comment
There was a problem hiding this comment.
Looks good to me! Is there a way to reliably reproduce the error? Can we add that as a test to prove that this is now fixed?
|
Thanks for the review Jaap!
Great thought! Unfortunately, I haven't had much luck getting a minimal reproducer to add as a test. My downstream package injects an |
Previously the `await group` was inside the for loop, effectively making it an async queue, where operations were performed in serial.
2 participants
This fixes an issue observed in downstream code, where awaiting a GraphQL subscription with
makeAsyncIterator().next()results in an error ofFatal error: attempt to await next() on more than one task. This encapsulates the consumption of the underlying resolver stream in a single cancellable task so that downstream code does not share the underlying stream iterator.This also fixes an issue where lists were not executed in parallel.